Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

content-visibility: add compat features #280

Merged
merged 2 commits into from
Nov 15, 2023

Conversation

ddbeck
Copy link
Collaborator

@ddbeck ddbeck commented Aug 3, 2023

Some ideas for reviewing this:

  • Are listed features plausible parts pieces of the feature as a whole?
  • Are any of the listed features later additions, part of a distinct sub feature, or otherwise excludable?
  • Are any pieces missing?

@ddbeck ddbeck added the feature definition Creating or defining new features or groups of features. label Aug 15, 2023
Copy link
Member

@tidoust tidoust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to #295, CSS Containment Level 3 extends the definition of content-visibility to make it animatable. How would we convey that change?

Co-authored-by: François Daoust <[email protected]>
@ddbeck
Copy link
Collaborator Author

ddbeck commented Oct 30, 2023

How would we convey that change?

I think there's two ways to look at it for this feature:

  1. Since this feature is pre-interoperable, it's possible that it will be animatable across browsers by the time everyone has implemented the rest of it. If we think that's likely, then we can include the animation subfeature from BCD now (on the assumption that's what the css.properties.content-visibility.keyframe_animatable feature refers to; see Point content-visibility animation spec to css-contain-3 mdn/browser-compat-data#21120).

  2. If we don't think animation will land with the rest of it, then we could create a follow-up feature for animation (e.g., content-visibility-animation or similar).

@tidoust
Copy link
Member

tidoust commented Nov 6, 2023

I think I'm clearer now on the generic mechanism to handle semantic updates. That's good.

I don't feel strongly on whether we should do 1. or 2., but in the absence of more implementation insights, I would follow the CSS working group's own assumptions: level 2 should become stable before level 3. As such, if we want to talk about the feature sooner rather than later, we should probably not include more future-looking level 3 bits.

Once in a while, the assumptions will turn out to be wrong, but that's why they're called "assumptions" and not "assertions"...

@foolip
Copy link
Collaborator

foolip commented Nov 15, 2023

I think that right now we don't need to assume anything about whether animation will be supported soon enough to be lumped into this feature. Down the line we'll most likely burn down BCD entries trying to match each to a feature, and then it will be clear if adding it into the content-visibility feature would change computed support or not.

@foolip foolip merged commit ba75a69 into web-platform-dx:main Nov 15, 2023
@ddbeck ddbeck deleted the 2023-08-03-new-feature branch November 16, 2023 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature definition Creating or defining new features or groups of features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants